We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bmqu::AlignedPrinter class has some problems:
bmqu::AlignedPrinter
bsl::vector<const char*>
bsl::vector<bsl::string>
const char*
bsl::strlen
blazingmq/src/groups/bmq/bmqu/bmqu_alignedprinter.h
Line 92 in e19ff33
Refactor bmqu::AlignedPrinter, so:
bsl::string
const bsl::vector<bsl::string>
d_fields_p
AlignedPrinter::AlignedPrinter
No response
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Is your feature request related to a problem?
bmqu::AlignedPrinter
class has some problems:bsl::vector<const char*>
argument which is strange. The conventional way is to passbsl::vector<bsl::string>
.const char*
length,bsl::strlen
is used.blazingmq/src/groups/bmq/bmqu/bmqu_alignedprinter.h
Line 92 in e19ff33
Describe the solution you'd like
Refactor
bmqu::AlignedPrinter
, so:bmqu::AlignedPrinter
constructor expectsbsl::string
, notconst char*
bmqu::AlignedPrinter
also stores these strings as aconst bsl::vector<bsl::string>
field (might be a pointer, might be a reference)d_fields_p
is not NULL in constructorAlignedPrinter::AlignedPrinter
or initialize this field as a referenceAlternatives you considered
No response
The text was updated successfully, but these errors were encountered: