Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resetAllChildAnimations() #45

Open
peterchappy opened this issue Sep 12, 2016 · 4 comments
Open

resetAllChildAnimations() #45

peterchappy opened this issue Sep 12, 2016 · 4 comments

Comments

@peterchappy
Copy link

Is there any reason why we wouldn't want the option to easily reset all child animations? I was having an animation bug because I was being dumb and thought that resetAnimation() would reset all the child animations too.

@benjaminbojko
Copy link
Collaborator

Hm, how about we pass a flag that would allow you to control that? E.g.

void BaseView::resetAnimations(const bool resetChildren = false);

@peterchappy
Copy link
Author

That would work, or we could have a different method for it too, but nevertheless I'll add this to my to-do list. Thanks Ben!

@benjaminbojko
Copy link
Collaborator

Thanks! The reason I'm leaning more towards a single method is that then it's clear to users what this method would do. Otherwise if we had resetAnimations() and resetAllChildAnimations() there's a little more room for interpretation in my mind.

@peterchappy
Copy link
Author

Fair enough. It's always nice to hear reasoning behind decisions like this.

@peterchappy peterchappy self-assigned this Oct 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants