Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove teams message from release workflow #1114

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

circlecube
Copy link
Member

redundant since there is a satis notice already.

It usually just sends the message "Bluehost plugin version ${GITHUB_REF#refs/tags/*} has been released!" anyways, and it also failed in the release today. Rather than tinker I think we can just remove it from this workflow.

Proposed changes

Type of Change

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING doc
  • Linting and tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@circlecube circlecube self-assigned this Jun 5, 2024
Copy link

cypress bot commented Jun 5, 2024

1 flaky test on run #8649 ↗︎

0 336 24 0 Flakiness 1

Details:

Merge 65e6f4d into 9ad81e4...
Project: Bluehost Brand Plugin Commit: 07f7d5281e ℹ️
Status: Passed Duration: 19:44 💡
Started: Jun 5, 2024 8:25 PM Ended: Jun 5, 2024 8:45 PM
Flakiness  vendor/newfold-labs/wp-module-ecommerce/tests/cypress/integration/Home/commerceHomePage.cy.js • 1 flaky test

View Output Video

Test Artifacts
Commerce Home Page- Next Steps > Verify Next steps when experience level is novice Test Replay Screenshots Video

Review all test suite changes for PR #1114 ↗︎

@circlecube circlecube merged commit 43b1536 into main Jun 5, 2024
10 of 23 checks passed
@circlecube circlecube deleted the update/release-workflow branch June 5, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants