From 23d889aa3a190751e7428cf1a5d00a70b3592751 Mon Sep 17 00:00:00 2001 From: Rafael Araujo Lehmkuhl Date: Tue, 15 Oct 2024 23:08:36 -0300 Subject: [PATCH] electron: Fix build of `arm64` flatpaks Previously the "arm" flatpak artifacts were actually x64 ones, worngly build and renamed. This commit also makes sure to use the exactly artifacts names on upload. --- .github/workflows/ci.yml | 21 +++++++++++++++++---- package.json | 2 +- 2 files changed, 18 insertions(+), 5 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index f3eb3e9c1..ca97e5fa7 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -134,7 +134,7 @@ jobs: uses: actions/upload-artifact@v3 with: name: Cockpit-${{ matrix.suffix }}-${{ matrix.arch }}-${{ env.VERSION }}.${{ matrix.extension }} - path: dist/Cockpit*.${{ matrix.extension }} + path: dist/Cockpit-${{ matrix.suffix }}-${{ matrix.arch }}-${{ env.VERSION }}.${{ matrix.extension }} if-no-files-found: error - name: Upload diff artifact (mac-only) @@ -223,17 +223,30 @@ jobs: - name: Set version as environment variable (others) run: echo "VERSION=$(git describe --tags --abbrev=0 | sed 's/^v//')" >> $GITHUB_ENV - - name: Build electron + - name: Build electron (arm) + if: matrix.os == 'ubuntu-24-arm' + run: | + bun install --frozen-lockfile + bun run build + env DEBUG="@malept/flatpak-bundler" bun run deploy:flatpak --arm64 + + - name: Build electron (x86_64) + if: matrix.os == 'ubuntu-latest' run: | bun install --frozen-lockfile bun run build - env DEBUG="@malept/flatpak-bundler" bun run deploy:flatpak + env DEBUG="@malept/flatpak-bundler" bun run deploy:flatpak --x64 + + - name: Rename 'aarch64' to 'arm64' + if: matrix.os == 'ubuntu-24-arm' + run: | + mv dist/Cockpit-${{ matrix.suffix }}-aarch64-${{ env.VERSION }}.${{ matrix.extension }} dist/Cockpit-${{ matrix.suffix }}-${{ matrix.arch }}-${{ env.VERSION }}.${{ matrix.extension }} - name: Upload Artifact uses: actions/upload-artifact@v3 with: name: Cockpit-${{ matrix.suffix }}-${{ matrix.arch }}-${{ env.VERSION }}.${{ matrix.extension }} - path: dist/Cockpit*.${{ matrix.extension }} + path: dist/Cockpit-${{ matrix.suffix }}-${{ matrix.arch }}-${{ env.VERSION }}.${{ matrix.extension }} if-no-files-found: error - name: Upload Release diff --git a/package.json b/package.json index 349c553ec..467f1e14c 100644 --- a/package.json +++ b/package.json @@ -10,7 +10,7 @@ "coverage": "vitest --coverage", "deploy:electron:dir": "ELECTRON=true electron-builder --dir", "deploy:electron": "ELECTRON=true electron-builder --publish=never -c.extraMetadata.version=$(git describe --tags --abbrev=0 | sed 's/^v//')", - "deploy:flatpak": "ELECTRON=true electron-builder --x64 --publish=never --linux flatpak -c.extraMetadata.version=$(git describe --tags --abbrev=0 | sed 's/^v//')", + "deploy:flatpak": "ELECTRON=true electron-builder --linux flatpak --publish=never -c.extraMetadata.version=$(git describe --tags --abbrev=0 | sed 's/^v//')", "dev": "vite --host", "dev:electron": "ELECTRON=true vite --host", "lint": "eslint . --ext .vue,.js,.jsx,.cjs,.mjs,.ts,.tsx,.cts,.mts --ignore-path .gitignore --max-warnings=0",