Specifically emit expired event for resumption failures

.changeset/loud-apes-listen.md

@@ -0,0 +1,5 @@
+---
+'@atproto/api': patch
+---
+
+Emit `expired` events for failed responses from `agent.resumeSession` instead of `create-failed`. `create-failed` events now reserved for unexpected exceptions, like a network timeout.

packages/api/src/agent.ts

@@ -159,23 +159,27 @@ export class AtpAgent {
     try {
       this.session = session
       const res = await this.api.com.atproto.server.getSession()
+      console.log('resumeSession', res)
       if (!res.success || res.data.did !== this.session.did) {
         throw new Error('Invalid session')
       }
       this.session.email = res.data.email
       this.session.handle = res.data.handle
       this.session.emailConfirmed = res.data.emailConfirmed
       this._updateApiEndpoint(res.data.didDoc)
+      this._persistSession?.('create', this.session)
       return res
-    } catch (e) {
+    } catch (e: any) {
+      console.error('resumeSession', e)
       this.session = undefined
-      throw e
-    } finally {
-      if (this.session) {
-        this._persistSession?.('create', this.session)
-      } else {
+
+      if (e.message.includes('Invalid session')) {
         this._persistSession?.('create-failed', undefined)
+      } else {
+        this._persistSession?.('unknown', undefined)
       }
+
+      throw e
     }
   }
 

packages/api/src/types.ts

@@ -3,7 +3,7 @@ import { LabelPreference } from './moderation/types'
 /**
  * Used by the PersistSessionHandler to indicate what change occurred
  */
-export type AtpSessionEvent = 'create' | 'create-failed' | 'update' | 'expired'
+export type AtpSessionEvent = 'create' | 'create-failed' | 'update' | 'expired' | 'unknown'
 
 /**
  * Used by AtpAgent to store active sessions