From 5560b7a25a5fe6d7c191bd6bbc8db2d5d1e3639e Mon Sep 17 00:00:00 2001
From: Devin Ivy <devinivy@gmail.com>
Date: Wed, 3 Jan 2024 16:41:07 -0500
Subject: [PATCH] Revert "lexicons: more string limits (#1994)"

This reverts commit ad0d976188d1f07401b9675b5c6045c91e82a84e.
---
 .changeset/odd-kids-warn.md           |  5 -----
 lexicons/app/bsky/embed/external.json | 26 +++++---------------------
 lexicons/app/bsky/embed/images.json   | 16 ++++------------
 packages/api/src/client/lexicons.ts   | 15 ---------------
 packages/bsky/src/lexicon/lexicons.ts | 15 ---------------
 packages/pds/src/lexicon/lexicons.ts  | 15 ---------------
 6 files changed, 9 insertions(+), 83 deletions(-)
 delete mode 100644 .changeset/odd-kids-warn.md

diff --git a/.changeset/odd-kids-warn.md b/.changeset/odd-kids-warn.md
deleted file mode 100644
index 021bda81456..00000000000
--- a/.changeset/odd-kids-warn.md
+++ /dev/null
@@ -1,5 +0,0 @@
----
-'@atproto/api': patch
----
-
-additional app.bsky.feed.post Lexicon string format limits
diff --git a/lexicons/app/bsky/embed/external.json b/lexicons/app/bsky/embed/external.json
index 85ef69ea4a2..8946382835f 100644
--- a/lexicons/app/bsky/embed/external.json
+++ b/lexicons/app/bsky/embed/external.json
@@ -18,16 +18,8 @@
       "required": ["uri", "title", "description"],
       "properties": {
         "uri": { "type": "string", "format": "uri" },
-        "title": {
-          "type": "string",
-          "maxGraphemes": 300,
-          "maxLength": 3000
-        },
-        "description": {
-          "type": "string",
-          "maxGraphemes": 1000,
-          "maxLength": 10000
-        },
+        "title": { "type": "string" },
+        "description": { "type": "string" },
         "thumb": {
           "type": "blob",
           "accept": ["image/*"],
@@ -50,17 +42,9 @@
       "required": ["uri", "title", "description"],
       "properties": {
         "uri": { "type": "string", "format": "uri" },
-        "title": {
-          "type": "string",
-          "maxGraphemes": 300,
-          "maxLength": 3000
-        },
-        "description": {
-          "type": "string",
-          "maxGraphemes": 1000,
-          "maxLength": 10000
-        },
-        "thumb": { "type": "string", "format": "uri" }
+        "title": { "type": "string" },
+        "description": { "type": "string" },
+        "thumb": { "type": "string" }
       }
     }
   }
diff --git a/lexicons/app/bsky/embed/images.json b/lexicons/app/bsky/embed/images.json
index 48106f62aa1..5baa7ab3f74 100644
--- a/lexicons/app/bsky/embed/images.json
+++ b/lexicons/app/bsky/embed/images.json
@@ -23,11 +23,7 @@
           "accept": ["image/*"],
           "maxSize": 1000000
         },
-        "alt": {
-          "type": "string",
-          "maxGraphemes": 5000,
-          "maxLength": 50000
-        },
+        "alt": { "type": "string" },
         "aspectRatio": { "type": "ref", "ref": "#aspectRatio" }
       }
     },
@@ -55,13 +51,9 @@
       "type": "object",
       "required": ["thumb", "fullsize", "alt"],
       "properties": {
-        "thumb": { "type": "string", "format": "uri" },
-        "fullsize": { "type": "string", "format": "uri" },
-        "alt": {
-          "type": "string",
-          "maxGraphemes": 5000,
-          "maxLength": 50000
-        },
+        "thumb": { "type": "string" },
+        "fullsize": { "type": "string" },
+        "alt": { "type": "string" },
         "aspectRatio": { "type": "ref", "ref": "#aspectRatio" }
       }
     }
diff --git a/packages/api/src/client/lexicons.ts b/packages/api/src/client/lexicons.ts
index dbbac6b7a2f..c0e7e51fddc 100644
--- a/packages/api/src/client/lexicons.ts
+++ b/packages/api/src/client/lexicons.ts
@@ -4775,13 +4775,9 @@ export const schemaDict = {
           },
           title: {
             type: 'string',
-            maxGraphemes: 300,
-            maxLength: 3000,
           },
           description: {
             type: 'string',
-            maxGraphemes: 1000,
-            maxLength: 10000,
           },
           thumb: {
             type: 'blob',
@@ -4810,17 +4806,12 @@ export const schemaDict = {
           },
           title: {
             type: 'string',
-            maxGraphemes: 300,
-            maxLength: 3000,
           },
           description: {
             type: 'string',
-            maxGraphemes: 1000,
-            maxLength: 10000,
           },
           thumb: {
             type: 'string',
-            format: 'uri',
           },
         },
       },
@@ -4856,8 +4847,6 @@ export const schemaDict = {
           },
           alt: {
             type: 'string',
-            maxGraphemes: 5000,
-            maxLength: 50000,
           },
           aspectRatio: {
             type: 'ref',
@@ -4901,16 +4890,12 @@ export const schemaDict = {
         properties: {
           thumb: {
             type: 'string',
-            format: 'uri',
           },
           fullsize: {
             type: 'string',
-            format: 'uri',
           },
           alt: {
             type: 'string',
-            maxGraphemes: 5000,
-            maxLength: 50000,
           },
           aspectRatio: {
             type: 'ref',
diff --git a/packages/bsky/src/lexicon/lexicons.ts b/packages/bsky/src/lexicon/lexicons.ts
index dbbac6b7a2f..c0e7e51fddc 100644
--- a/packages/bsky/src/lexicon/lexicons.ts
+++ b/packages/bsky/src/lexicon/lexicons.ts
@@ -4775,13 +4775,9 @@ export const schemaDict = {
           },
           title: {
             type: 'string',
-            maxGraphemes: 300,
-            maxLength: 3000,
           },
           description: {
             type: 'string',
-            maxGraphemes: 1000,
-            maxLength: 10000,
           },
           thumb: {
             type: 'blob',
@@ -4810,17 +4806,12 @@ export const schemaDict = {
           },
           title: {
             type: 'string',
-            maxGraphemes: 300,
-            maxLength: 3000,
           },
           description: {
             type: 'string',
-            maxGraphemes: 1000,
-            maxLength: 10000,
           },
           thumb: {
             type: 'string',
-            format: 'uri',
           },
         },
       },
@@ -4856,8 +4847,6 @@ export const schemaDict = {
           },
           alt: {
             type: 'string',
-            maxGraphemes: 5000,
-            maxLength: 50000,
           },
           aspectRatio: {
             type: 'ref',
@@ -4901,16 +4890,12 @@ export const schemaDict = {
         properties: {
           thumb: {
             type: 'string',
-            format: 'uri',
           },
           fullsize: {
             type: 'string',
-            format: 'uri',
           },
           alt: {
             type: 'string',
-            maxGraphemes: 5000,
-            maxLength: 50000,
           },
           aspectRatio: {
             type: 'ref',
diff --git a/packages/pds/src/lexicon/lexicons.ts b/packages/pds/src/lexicon/lexicons.ts
index dbbac6b7a2f..c0e7e51fddc 100644
--- a/packages/pds/src/lexicon/lexicons.ts
+++ b/packages/pds/src/lexicon/lexicons.ts
@@ -4775,13 +4775,9 @@ export const schemaDict = {
           },
           title: {
             type: 'string',
-            maxGraphemes: 300,
-            maxLength: 3000,
           },
           description: {
             type: 'string',
-            maxGraphemes: 1000,
-            maxLength: 10000,
           },
           thumb: {
             type: 'blob',
@@ -4810,17 +4806,12 @@ export const schemaDict = {
           },
           title: {
             type: 'string',
-            maxGraphemes: 300,
-            maxLength: 3000,
           },
           description: {
             type: 'string',
-            maxGraphemes: 1000,
-            maxLength: 10000,
           },
           thumb: {
             type: 'string',
-            format: 'uri',
           },
         },
       },
@@ -4856,8 +4847,6 @@ export const schemaDict = {
           },
           alt: {
             type: 'string',
-            maxGraphemes: 5000,
-            maxLength: 50000,
           },
           aspectRatio: {
             type: 'ref',
@@ -4901,16 +4890,12 @@ export const schemaDict = {
         properties: {
           thumb: {
             type: 'string',
-            format: 'uri',
           },
           fullsize: {
             type: 'string',
-            format: 'uri',
           },
           alt: {
             type: 'string',
-            maxGraphemes: 5000,
-            maxLength: 50000,
           },
           aspectRatio: {
             type: 'ref',