Skip to content

Why is cid null, for deletion events? #1252

Discussion options

You must be logged in to vote

Here are some middling arguments against including the cid:

  • extra bytes on the wire, waste of resources in many cases
  • draws less attention to the content which has been removed
  • implementation performance flexibility

I don't think we have a really strong reason why we don't include it. I can see that it would be helpful in some cases, though I suspect that the majority of downstream services which are trusting the firehose stream (as opposed to keeping a local mirror of the repo to validate events against) wouldn't even be indexing with the CID, just the rkey.

Replies: 1 comment

Comment options

You must be logged in to vote
0 replies
Answer selected by bnewbold
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants