Add bookmarks

[venteto]

This seems like it would be almost as straigthforward as copying and pasting the code that implements Likes and then renaming the client menu entry?

[RobotoSkunk]

I'll bump this because it might be useful

[qazmlp]

Bookmarks are probably expected to be private. (Likes are public, just not surfaced.)
That means the implementation would have to be pretty different, conceptually more similar to that of mutes I think.

There's a feature request in the social-app repo here: bluesky-social/social-app#1091

[davidcelis]

I posted a similar message in the linked issue (bluesky-social/social-app#1091) but I'll share it here as well, because I think bookmarks should be implemented in the protocol rather than the social app.

I agree that Bluesky needs native support for bookmarks; this is a feature that people have come to expect from social networks like this. The 📌 feed is an interesting workaround, but this post from @pfrazee makes me worry about support for workarounds entering the codebase for the social app rather than doing the work on protocol-level support for bookmarks. I also think it has to be part of the protocol itself instead of just the social app because people will expect their bookmarks to be viewable from any device or from the web, meaning the app shouldn't be storing them as separate state.

Looking through the lexicons, I'm not sure it's as simple as duplicating Likes except making it a method on .repo; as far as I can tell, most com.atproto.repo procedures do not require auth, including com.atproto.repo.getRecord. I may be misunderstanding whether or not repo records can truly be public or private, but it seems that all records are meant to be public.

I also agree that duplicating mutes makes more sense than duplicating likes. As far as I can tell, most com.atproto.repo procedures do not require auth, including com.atproto.repo.getRecord. I may be misunderstanding whether or not repo records can truly be public or private, but it seems like all records are meant to be public?

While I was looking through the existing lexicons, I wasn't sure that there was any existing package within the app.bsky namespace that makes sense for bookmarks. Mutes are in app.bsky.graph, but bookmarks aren't really a social graph concern. I thought app.bsky.actor or com.atproto.server might make sense, but the former seems very focused on onboarding and user settings (and people would probably argue, correctly, that bookmarks aren't settings), and the latter seems very focused on credentials.

Maybe we need a new small app.bsky.bookmark package for this that follows the similar "require auth, only create and enumerate records for the actor" pattern present for mutes?

[ebwinters]

The initial work at the lexicon and now client level is being done by myself and members of the lexicon-community org.
Here is the recently merged lexicon
Here is a draft of a client package for consumption in Bluesky or other app views

I could use some help doing the UI implementation in Bluesky, but the POC is done

[danielbayley]

I could use some help doing the UI implementation in Bluesky, but the POC is done

@ebwinters Since a new bookmark icon will be needed, to match these as part of this, I threw up a quick PR. See bluesky-social/social-app#7231. (Full disclosure, I'm a core contributor to Lucide icons…)