Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build system rework #1941

Closed
wants to merge 1 commit into from
Closed

Build system rework #1941

wants to merge 1 commit into from

Conversation

matthieusieben
Copy link
Contributor

@matthieusieben matthieusieben commented Dec 7, 2023

Improvements

  • Every single js/ts file (not part of build results) is type checked
  • Every single js/ts file is linted
  • A single tsc --build will generate all the compiled js & d.ts files (except for pds-template, that uses handlebars)

Issues

  • There are multiple circular dependencies
    • the package dev-env depends on packages bsky, api, pds, all of which depend on dev-env
    • in crypto, there is a cicural depedendency between did.ts > plugins.ts > p256/plugin.ts > p256/operations.ts > did.ts

@matthieusieben
Copy link
Contributor Author

Reworked in #2169

@matthieusieben matthieusieben deleted the chore-build-revamp branch February 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant