Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phone verification bypass number #2119

Merged
merged 2 commits into from
Feb 1, 2024
Merged

Phone verification bypass number #2119

merged 2 commits into from
Feb 1, 2024

Conversation

dholms
Copy link
Collaborator

@dholms dholms commented Jan 31, 2024

Add a specially configured phone number that allows you to bypass required phone verification on createAccount

@dholms dholms changed the base branch from main to multi-pds-auth January 31, 2024 22:30
devinivy
devinivy reviewed Jan 31, 2024
View reviewed changes
packages/pds/src/api/com/atproto/server/createAccount.ts
return undefined
}

if (!code) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might consider trimming the code before this check.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice yup 👍

@dholms dholms merged commit 86655ea into multi-pds-auth Feb 1, 2024
10 checks passed
@dholms dholms deleted the bypass-phone-number branch February 1, 2024 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinivy devinivy devinivy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dholms @devinivy