Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Load more" button shows when there's nothing to load #195

Closed
heikadog opened this issue Sep 20, 2024 · 3 comments
Closed

"Load more" button shows when there's nothing to load #195

heikadog opened this issue Sep 20, 2024 · 3 comments

Comments

@heikadog
Copy link

heikadog commented Sep 20, 2024

The "Load more" button shows in multiple places when there's nothing to load—is there a chance this could be hidden?

@heikadog heikadog changed the title "Load more ." button my "Load more" button shows when there's nothing to load Sep 20, 2024
@mary-ext
Copy link

This PR seems to suggest it's intentional, as a way to refresh the content, I wonder if changing the label would be a lot more helpful?

@heikadog
Copy link
Author

heikadog commented Oct 2, 2024

yeah, i feel like it should say "Refresh" instead

@foysalit
Copy link
Contributor

We fixed that issue with the load more button showing up in the queue page. It was mostly happening because of client side filtering of queues.
However, there are a couple other places where we get a cursor for the last item in the list and loading more from that cursor just returns the empty page. I don't think we have a quick way to solve this without an additional query somewhere tbh.

I'm sure we will revisit this at some point but unfortunately, I doubt it will be any time soon due to other priorities.

@foysalit foysalit closed this as not planned Won't fix, can't repro, duplicate, stale Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants