From 72550df0e2c94bd17b86215d95ec1b7eb76fe30f Mon Sep 17 00:00:00 2001
From: Hailey <me@haileyok.com>
Date: Thu, 16 May 2024 12:21:29 -0700
Subject: [PATCH] Properly update badge for other unread notifications (#4052)

* decrement badge count for chats

* handle decrement in `useMarkAsRead`

* remove async

* remove setting badge count

* oops

* update the number correctly

* nit
---
 src/state/queries/notifications/unread.tsx | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/src/state/queries/notifications/unread.tsx b/src/state/queries/notifications/unread.tsx
index 80333b524f..9d35ee19fb 100644
--- a/src/state/queries/notifications/unread.tsx
+++ b/src/state/queries/notifications/unread.tsx
@@ -4,15 +4,14 @@
 
 import React from 'react'
 import {AppState} from 'react-native'
-import * as Notifications from 'expo-notifications'
 import {useQueryClient} from '@tanstack/react-query'
 import EventEmitter from 'eventemitter3'
 
 import BroadcastChannel from '#/lib/broadcast'
 import {logger} from '#/logger'
-import {isNative} from '#/platform/detection'
 import {useMutedThreads} from '#/state/muted-threads'
 import {useAgent, useSession} from '#/state/session'
+import {decrementBadgeCount} from 'lib/notifications/notifications'
 import {useModerationOpts} from '../../preferences/moderation-opts'
 import {truncateAndInvalidate} from '../util'
 import {RQKEY as RQKEY_NOTIFS} from './feed'
@@ -120,9 +119,7 @@ export function Provider({children}: React.PropsWithChildren<{}>) {
         // update & broadcast
         setNumUnread('')
         broadcast.postMessage({event: ''})
-        if (isNative) {
-          Notifications.setBadgeCountAsync(0)
-        }
+        decrementBadgeCount(Math.min(cacheRef.current.unreadCount, 30))
       },
 
       async checkUnread({
@@ -163,9 +160,6 @@ export function Provider({children}: React.PropsWithChildren<{}>) {
               : unreadCount === 0
               ? ''
               : String(unreadCount)
-          if (isNative) {
-            Notifications.setBadgeCountAsync(Math.min(unreadCount, 30))
-          }
 
           // track last sync
           const now = new Date()