Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Share Extension - some images show up as file URLs #5492

Closed
jaronheard opened this issue Sep 26, 2024 · 3 comments · Fixed by #5515
Closed

Share Extension - some images show up as file URLs #5492

jaronheard opened this issue Sep 26, 2024 · 3 comments · Fixed by #5515
Labels
bug Something isn't working

Comments

@jaronheard
Copy link

Describe the bug

Some images images show up as file URLs instead of images when shared through the share extension. Note, I have a fix shared in additional context.

To Reproduce

Steps to reproduce the behavior:

  1. Open a photo in iMessage by tapping on it
  2. Share to Bluesky from that view
  3. Observe that the share content is file:///... and not an image

Expected behavior

The image shared is the image and not a file:/// link

Screenshots

Details

  • Platform: iOS
  • Platform version: 18.1
  • App version: 1.91.1.464 2feb5be (prod)

Additional context

I am using an adopted version of the bluesky share extension code for my app and fixed this by reordering the if statement that checks the content type to put the URL check last (PR)

Tagging @haileyok since this is your work and saw in an in-flight PR in-flight share extension PR... hope this is helpful since your code helped me!

@jaronheard jaronheard added the bug Something isn't working label Sep 26, 2024
@surfdude29
Copy link
Contributor

I can reproduce this on iOS 15.8.3 and iOS 17.7.

@haileyok
Copy link
Contributor

Lets try to fix...

@haileyok
Copy link
Contributor

Got it! Thanks for flagging that @jaronheard!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants