Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repost button styling when logged out #6222

Merged
merged 1 commit into from
Nov 23, 2024

Conversation

rolandcrosby
Copy link
Contributor

On the web, the logged-out variant of the repost button sets a white background with variant="ghost", which conflicts with the background applied when a post is hovered:
Screenshot 2024-11-10 at 9 35 34 PM

Removing the button styling seems to make this button render like the others on the page:
Screenshot 2024-11-10 at 9 36 22 PM

@surfdude29
Copy link
Contributor

Nice catch! I had a hard time seeing the difference between the two screenshots at first 😄

Copy link

@mmraz mmraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@gaearon gaearon merged commit 30af267 into bluesky-social:main Nov 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants