Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim_motor _move not moving in the correct direction with negative value. #476

Open
Relm-Arrowny opened this issue Jul 23, 2024 · 0 comments · May be fixed by #670
Open

sim_motor _move not moving in the correct direction with negative value. #476

Relm-Arrowny opened this issue Jul 23, 2024 · 0 comments · May be fixed by #670

Comments

@Relm-Arrowny
Copy link
Contributor

I believe to keep track of direction in sim_motor the follow should be:

distance = new_position - old_position

Rather than

distance = abs(new_position - old_position)

Ref
https://github.com/bluesky/ophyd-async/blob/ef1c9426cb20c597a7614686aa01cbf9d43d11ac/src/ophyd_async/sim/demo/sim_motor.py#L46C18-L46C52

@coretl coretl linked a pull request Nov 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant