Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress component tests #25

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Added progress component tests #25

merged 1 commit into from
Jul 9, 2024

Conversation

kamaroly
Copy link
Collaborator

@kamaroly kamaroly commented Jul 9, 2024

Changelist
Added tests for progress component

Summary by Sourcery

This pull request introduces tests for the progress component, verifying its correct rendering with given attributes.

  • Tests:
    • Added tests for the progress component to ensure it renders correctly with specified attributes.

Copy link

sourcery-ai bot commented Jul 9, 2024

Reviewer's Guide by Sourcery

This pull request adds a new test file for the progress component. The test ensures that the progress component renders correctly with the specified HTML structure and CSS classes.

File-Level Changes

Files Changes
test/salad_ui/progress_test.exs Added a new test file for the progress component, including a test case to verify its rendering.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kamaroly - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@kamaroly kamaroly merged commit 4dcc176 into main Jul 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant