Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have massof(Species()) and chargeof(Species()) throw an error. #121

Open
DavidSagan opened this issue Jan 7, 2025 · 2 comments
Open

Have massof(Species()) and chargeof(Species()) throw an error. #121

DavidSagan opened this issue Jan 7, 2025 · 2 comments

Comments

@DavidSagan
Copy link
Member

Right now, massof(Species()) and chargeof(Species()) just return 0. Throwing an error would make the code much safer. Anyone have any objections?

@rot4te
Copy link
Collaborator

rot4te commented Jan 7, 2025 via email

@rot4te
Copy link
Collaborator

rot4te commented Feb 6, 2025

Turns out this is a bit weird.
For some reason the definition of massof is now inside the APCdef macro, which I don't think it should be.
Furthermore, it's defined as a constant, rather than a function. This is true for chargeof as well. Did I miss a conversation about this? It makes more sense to me that the massof and chargeof functions get defined with the other particle functions and exported.
I'll do that in a branch and we can talk about it next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants