Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Catch UnicodeDecodeError in lobster-json #102

Closed
phiwuu opened this issue Oct 17, 2024 · 0 comments · Fixed by #103
Closed

Catch UnicodeDecodeError in lobster-json #102

phiwuu opened this issue Oct 17, 2024 · 0 comments · Fixed by #103
Assignees
@phiwuu
Labels
lobster-json Affects JSON integration

Comments

@phiwuu
Copy link
Member

phiwuu commented Oct 17, 2024 •
edited
Loading

Opening input files, which are not encoded with UTF-8, might lead to an uncaught UnicodeDecodeError error.
This is not convenient for the user, only software developers will understand it.

I recommend to catch the error, print a meaningful message, and exit with error code 1.

This is the location where the error is raised:

lobster/lobster/tools/json/json.py

Line 111 in 948471a

data = json.load(fd)

See also #100
@phiwuu phiwuu added the lobster-json Affects JSON integration label Oct 17, 2024
@phiwuu phiwuu self-assigned this Oct 17, 2024
phiwuu added a commit that referenced this issue Oct 17, 2024
@phiwuu
Catch UnicodeDecodeError in lobster-json
240d335 
The `UnicodeDecodeError` is catched,
and an error message is printed.
Afterwards `lobster-json` exits.

Issue: #102
@phiwuu phiwuu mentioned this issue Oct 17, 2024
Merged
@phiwuu phiwuu linked a pull request Oct 17, 2024 that will close this issue
Catch UnicodeDecodeError in lobster-json #103
Merged
phiwuu added a commit that referenced this issue Oct 22, 2024
@phiwuu
Catch UnicodeDecodeError in lobster-json
8e72013 
The `UnicodeDecodeError` is catched,
and an error message is printed.
Afterwards `lobster-json` exits.

Issue: #102
phiwuu added a commit that referenced this issue Oct 22, 2024
@phiwuu
Catch UnicodeDecodeError in lobster-json (#103)
69635b8 
The `UnicodeDecodeError` is catched, and an error message is printed.
Afterwards `lobster-json` exits.

Issue: #102
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phiwuu phiwuu

Labels
lobster-json Affects JSON integration
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Catch UnicodeDecodeError in lobster-json bmw-software-engineering/lobster
1 participant
@phiwuu