Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lobster-online-report shall not modify the input, but generate new output, to support bazel #28

Closed
phiwuu opened this issue Mar 26, 2024 · 0 comments · Fixed by #40
Closed

lobster-online-report shall not modify the input, but generate new output, to support bazel #28

phiwuu opened this issue Mar 26, 2024 · 0 comments · Fixed by #40
Labels
lobster-core Affects core LOBSTER tools

Comments

@phiwuu
Copy link
Member

phiwuu commented Mar 26, 2024

Bazel requires that there is always an input and an output to a tool, so that Bazel can use smart caching mechanisms.
Unfortunately lobster-online-report modifies the input file.

Please add a new command line flag --out that allows to specify the output file. If no value is given, then the input file is modified (for backward compatibility).
@phiwuu phiwuu added the lobster-core Affects core LOBSTER tools label Mar 26, 2024
@phiwuu phiwuu pinned this issue May 13, 2024
@christophkloeffel christophkloeffel mentioned this issue Jun 14, 2024
Merged
@christophkloeffel christophkloeffel linked a pull request Jun 14, 2024 that will close this issue
adds argument --out to online_report tool #40
Merged
@phiwuu phiwuu unpinned this issue Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lobster-core Affects core LOBSTER tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds argument --out to online_report tool christophkloeffel/lobster
1 participant
@phiwuu