-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lobster-python
shall not use line number as identifier
#58
Labels
lobster-python
Affects Python integration
Comments
kedarnn
added a commit
that referenced
this issue
Sep 16, 2024
The identifier now uses counter if there exists multiple functions with same name. Issue #58
phiwuu
pushed a commit
that referenced
this issue
Sep 16, 2024
The identifier now uses counter if there exists multiple functions with same name. Issue #58
kedarnn
added a commit
that referenced
this issue
Sep 16, 2024
The identifier now uses counter if there exists multiple functions with same name. Issue #58
phiwuu
added a commit
that referenced
this issue
Sep 17, 2024
…#67) The identifier uses counter if there exist multiple functions with the same name. Issue #58 --------- Co-authored-by: Kedar Navare <[email protected]> Co-authored-by: Philipp Wullstein-Kammler <[email protected]>
mugdhadhole1
pushed a commit
that referenced
this issue
Oct 9, 2024
…#67) The identifier uses counter if there exist multiple functions with the same name. Issue #58 --------- Co-authored-by: Kedar Navare <[email protected]> Co-authored-by: Philipp Wullstein-Kammler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
See comment #39 (comment)
lobster-python
shall not use line numbers as unique identifiers.Instead, use the following logic to deduce the name inside the lobster file:
Example:
Python file 1:
First
func
becomesfunc
Second
func
becomesfunc-2
Third
func
becomesfunc-3
and so on
Python file 2:
First
func
becomesfunc
Second
func
becomesfunc-2
Third
func
becomesfunc-3
and so on
Consider the following Python code
file.py
:The expected
lobster-python
output file shall look like this:The new feature here are the lines
"tag": "python file.hello_world"
and"tag": "python file.hello_world-2"
.No line number shall be appended, but instead a counter (starting from 2).
If
hello_world
orhello_universe
are defined again in different files, then the generation of the tags shall not be influenced by those other files. That is, the tag generator shall only look at one single file at a time.The text was updated successfully, but these errors were encountered: