Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LOBSTER-Cpptest tool to use configuration files #140

Merged
merged 1 commit into from
Dec 17, 2024
Merged

LOBSTER-Cpptest tool to use configuration files #140

merged 1 commit into from
Dec 17, 2024

Conversation

SurajBDeore
Copy link
Contributor

  • Replaced command-line arguments with a YAML-based configuration file for improved usability and maintainability.
  • Simplifies parameter management and enhances readability.

@SurajBDeore SurajBDeore requested a review from a team as a code owner December 5, 2024 07:40
@SurajBDeore SurajBDeore force-pushed the feature/lobster-cpptest-cmd-to-config branch from c945916 to 2e992fa Compare December 5, 2024 08:33
@phiwuu phiwuu added the lobster-cpptest Affects lobster-cpptest label Dec 6, 2024
@SurajBDeore SurajBDeore force-pushed the feature/lobster-cpptest-cmd-to-config branch 2 times, most recently from 9de144b to 29b8f61 Compare December 11, 2024 08:34
mugdhadhole1
mugdhadhole1 reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@mugdhadhole1 mugdhadhole1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The markers accept @ as a parameter and error is not handled

other_tests.lobster:
    markers: [@]

    kind: ""

@SurajBDeore
Copy link
Contributor Author

The markers accept @ as a parameter and error is not handled

other_tests.lobster:
    markers: [@]

    kind: ""

json is invalid, please try with double quote then it will work properly

phiwuu
phiwuu requested changes Dec 12, 2024
View reviewed changes
Copy link
Member

@phiwuu phiwuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. Let's build a new release first, and merge afterwards.

@SurajBDeore @phiwuu
LOBSTER-Cpptest tool to use configuration files
7874f8a 
- Replaced command-line arguments with a YAML-based configuration file for improved usability and maintainability.
- Simplifies parameter management and enhances readability.
@phiwuu phiwuu force-pushed the feature/lobster-cpptest-cmd-to-config branch from 29b8f61 to 7874f8a Compare December 17, 2024 11:10
@phiwuu phiwuu enabled auto-merge (squash) December 17, 2024 11:12
@phiwuu phiwuu merged commit eb9dade into main Dec 17, 2024
24 checks passed
@phiwuu phiwuu deleted the feature/lobster-cpptest-cmd-to-config branch December 17, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mugdhadhole1 mugdhadhole1 mugdhadhole1 left review comments

@phiwuu phiwuu phiwuu approved these changes

Assignees
No one assigned
Labels
lobster-cpptest Affects lobster-cpptest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SurajBDeore @phiwuu @mugdhadhole1