Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selenium system test into CI for html_report #148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

selenium system test into CI for html_report #148

wants to merge 1 commit into from

Conversation

SurajBDeore
Copy link
Contributor

No description provided.

@SurajBDeore SurajBDeore requested a review from a team as a code owner December 10, 2024 11:29
@SurajBDeore SurajBDeore force-pushed the feature/selenium-into-CI branch 16 times, most recently from 2b88d51 to e54c043 Compare December 12, 2024 08:26
@phiwuu phiwuu added the internal Affects the CI, tests or refactorings only, not relevant to the end-user label Dec 12, 2024
@SurajBDeore SurajBDeore force-pushed the feature/selenium-into-CI branch 10 times, most recently from 85bee83 to 845a4bb Compare December 12, 2024 13:34
@SurajBDeore SurajBDeore force-pushed the feature/selenium-into-CI branch from 845a4bb to e96e2c8 Compare December 13, 2024 10:55
kedarnn
kedarnn reviewed Dec 23, 2024
View reviewed changes
Copy link
Contributor

@kedarnn kedarnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the review comments that we discussed for further reference.

  1. Makefile - Make the execution on a folder instead of a single file.
  2. Create a class for grouping the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kedarnn kedarnn kedarnn left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
internal Affects the CI, tests or refactorings only, not relevant to the end-user
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SurajBDeore @kedarnn @phiwuu