Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test/items py #74

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Unit test/items py #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a8fb285
unit tests for items.py file
mugdhadhole1 Sep 12, 2024
8a7532c
updated the test system files where the line numbers need to be removed
mugdhadhole1 Sep 13, 2024
0f2bed8
unit tests for items.py file
mugdhadhole1 Sep 12, 2024
a6ebad2
Created separate tests for test_from_json function of each class
mugdhadhole1 Oct 9, 2024
76878be
unit tests for items.py file
mugdhadhole1 Sep 12, 2024
9863c1b
Removed the code which added an extra new line at the end of output f…
mugdhadhole1 Oct 11, 2024
5743f13
Inherited ItemsTests class and accessed properties and methods using …
mugdhadhole1 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lobster/tools/python/python.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,6 @@ def main():
if options.out:
with open(options.out, "w", encoding="UTF-8") as fd:
lobster_write(fd, schema, "lobster_python", items)
fd.write("\n")
kedarnn marked this conversation as resolved.
Show resolved Hide resolved
print("Written output for %u items to %s" % (len(items),
options.out))
else:
Expand Down
1 change: 0 additions & 1 deletion test-system/lobster-python/basic.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,4 +63,3 @@ Written output for 3 items to basic.lobster
"schema": "lobster-imp-trace",
"version": 3
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change really necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously make test-ci command added two empty lines at the end of the content in output files
I made this change to remove the extra lines.

In recent commit, I have removed the code which added extra empty line to the end of content in output files,
now you will see only one empty line at the end of content in those output files

1 change: 0 additions & 1 deletion test-system/lobster-python/multiple_identical_function_names.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,4 +103,3 @@ Written output for 6 items to multiple_identical_function_names.lobster
"schema": "lobster-imp-trace",
"version": 3
}

1 change: 0 additions & 1 deletion test-system/lobster-python/pytest_mark.output
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,4 +48,3 @@ Written output for 2 items to pytest_mark.lobster
"schema": "lobster-act-trace",
"version": 3
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change really necessary?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously make test-ci command added two empty lines at the end of the content in output files
I made this change to remove the extra lines.

In recent commit, I have removed the code which added extra empty line to the end of content in output files,
now you will see only one empty line at the end of content in those output files

Loading
Loading