Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[th/flake8] add flake8 support (with .flake8 config, github action and fix warnings) #23

Merged
merged 4 commits into from
Sep 12, 2024
Merged

[th/flake8] add flake8 support (with .flake8 config, github action and fix warnings) #23

merged 4 commits into from
Sep 12, 2024

Commits on Aug 27, 2024

  1. all: cleanup imports 

    - sort imports
  - by name
  - imports from stdlib and pip modules first
  - "import" before "from x import"

- wrap lienes so that each import line only imports one name.
    @thom311
    thom311 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    8745060 View commit details
    Browse the repository at this point in the history

  2. requirements: add requirements.txt file with pip modules

    @thom311
    thom311 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a085495 View commit details
    Browse the repository at this point in the history

  3. flake8: fix various flake8 warnings 

    ./dpu-tools/dpu-tools:61:9: F841 local variable device is assigned to but never used
./dpu-tools/dpu-tools:62:9: F841 local variable function is assigned to but never used
./pxeboot:513:22: C400 Unnecessary generator - rewrite as a list comprehension.
./reset:20:5: F841 local variable bf_pci is assigned to but never used
    @thom311
    thom311 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    90c3754 View commit details
    Browse the repository at this point in the history

  4. flake8: add ".flake8" configuration file 

    We need to this at least suppress E203. E203 is about
whitespace formatting and conflicts with python-black.
Black is the formatter that we use.
    @thom311
    thom311 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    a893496 View commit details
    Browse the repository at this point in the history