fix: recover node buffer list trie nodes for graceful kill #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
force-pushed
the
fix-recovernbl
branch
from
c6fda3c
to
c053afb
Compare
sysvm
force-pushed
the
fix-recovernbl
branch
from
959a23b
to
68750ff
Compare
sysvm
force-pushed
the
fix-recovernbl
branch
from
68750ff
to
6b11a70
Compare
bnoieh
pushed a commit
to bnoieh/op-geth
that referenced
this pull request
Nov 29, 2024
core/types: SetBlobTxSidecar to support blob tx tooling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr aims to recover node buffer list data for graceful kill. Therefore, both graceful kill and force kill can recover data by freezerdb.
Rationale
When using graceful kill to stop geth, the data in nodebufferlist is stored in db or journalFile. When nodebufferlist recovers data by loading all data into nodebufferlist base buffer, if the data is too large, it will exceed the pebble batch size limit and cause panic. By this pr, both graceful kill and force kill can use the same functions to recover data.
Example
N/A
Changes
Notable changes: