-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error when doing require('node-read') #26
Comments
did you do |
Yes, I installed node-read 0.1.6. I probably should have mentioned that I'm actually using it in the browser with browserify. I used node-readability before and wanted to try node-read instead... |
The code that you provided doesn't come from node-read. I can't really debug it. Can you provide some more context? |
@bndr let me try. Looking into the calling stack I see the following:
Does this help at all? |
I've updated the cheerio dependency version, can you try it again? Version 0.1.7 of node-read |
I updated to 0.1.7 but it didn't seem to update anything about cheerio. npm ls cheerio yields:
In any case still getting the same error |
I don't really know what the problem is, I never used browserify. Maybe you can try this: https://wzrd.in/standalone/node-read@latest |
I don't think it's got to do with browserify - if I replace node-read with node-readability everything works just fine. |
How are you calling browserify? did you try with --standalone? |
I'm not calling it directly. My server side is rails and I use the gem browserify-rails. Seems to work nicely as it allows me to write complex javascript with support for commonjs, React, etc. Not sure how to use it separately... |
According to the readme at https://github.com/browserify-rails/browserify-rails/blob/master/README.md
Can you try adding --standalone? |
ok, tried it. Loads ok with node-readability but still getting an error with node-read, albeit a different one. Here is the error and "calling stack":
|
What version of browserify is installed? |
9.0.7 |
Can you try upgrading it to 12.0.1? |
I think 9.0.7 is what I have installed globally but as part of my project I have So I think it is ok. |
Was just a sudo missing. Updated global browserify to 12.0.1 but still getting same error when requiring node-read... |
I'm getting:
Seems to happen here:
Without the require my project runs without an issue...
Am I missing some dependency or anything?
The text was updated successfully, but these errors were encountered: