Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Express 4.x? #462

Open
goldfire opened this issue Apr 12, 2014 · 15 comments
Open

Support for Express 4.x? #462

goldfire opened this issue Apr 12, 2014 · 15 comments
Labels

Comments

@goldfire
Copy link

Are there any plans to update this to support Express 4.x?

@maruf89
Copy link

maruf89 commented May 9, 2014

+1

5 similar comments
@forty4
Copy link

forty4 commented May 15, 2014

+1

@richtera
Copy link

+1

@jeffgca
Copy link

jeffgca commented May 26, 2014

+1

@jhonber
Copy link

jhonber commented Jun 23, 2014

+1

@ghost
Copy link

ghost commented Jul 14, 2014

+1

@CCVonLewin
Copy link

@bnoguchi, We are all very grateful for the work you have put into everyauth and we understand the difficult balance of work, life and a side project(s). Lots of developers have come to depend on this specific package and are feening to move their apps to Express 4. I understand time is probably the biggest factor but could I offer you $ to get it into your schedule? If you are already working on it, awesome, I still would contribute $ just because you deserve it. Any feedback would be super helpful.

@bnoguchi
Copy link
Owner

@CCVonLewin Thanks for the kick in the butt :) I started a new branch this past wknd. The new branch will support Express 4 and will also simplify some of the implementation of everyauth. I hope to finish it this weekend or by the subsequent weekend, time permitting.

@bnoguchi
Copy link
Owner

bnoguchi commented Aug 3, 2014

So I finished a first draft of a re-write of core everyauth today. See the example/ directory to get a feel for the changes. I only migrated the Facebook login module over. I need to migrate the other modules over and then clean up the re-write of core. If you'd like to help me migrate the other modules, send me a message, and I'll add you to the new https://github.com/everyauth group, where the modules will live.

I'm going to hold off on publishing to npm for now, but try this branch out in the meantime.

https://github.com/bnoguchi/everyauth/tree/0.5.x

Here's a quick summary of what's different:

  • All modules like facebook, twitter, etc except everyauth core will now live at https://github.com/everyauth. This will make it much easier to deliver updates to specific modules, and it should make contributing to everyauth much easier. I've already updated and moved the implementations of oauth2 and facebook to this new home. Get in touch if you want to help with migrations.
  • Everyauth no longer magically takes care of routing for you. Instead, you should explicitly declare your routes and use everyauth as middleware or route handlers for your routes. This leads to more readable code because you'll know exactly where to look to find every one of your routes, instead of wondering what routes everyauth magically created underneath the hood. This also affords more flexibility in what you're able to accomplish with both upstream and downstream middleware relative to everyauth's route middleware.
  • I'm moving away from Everyauth's error handling API, instead allowing you to explicitly leverage Express's error handling via its typical next callback. In the body of next, you'll be able to determine how you want to handle specific custom Errors exposed via an everyauth module via some instanceof checks. This should simplify the code. Before, error handling was complex because you had to think about how Everyauth allowed you to define error handling and how to glue that to the way express allowed you to handle errors. We're doing away with that in favor of using what Express already provides.

If you have any questions, let me know. It's late over here, but I wanted to send an update out to this thread about the changes and upcoming new release.

@inolasco
Copy link

+1

If anyone wants to try the 0.5.x preview, add dependency:

"everyauth": "git://github.com/bnoguchi/everyauth.git#0.5.x"

In case you do not know already how to add github dependencies, which I didn't :P

@ilanbiala
Copy link

Any progress on this?

@bnoguchi
Copy link
Owner

bnoguchi commented Dec 4, 2014

There's a branch that already works for express 4.x. I'll document and push
info about this tonight and re-post on this thread.

Brian Noguchi
415.793.2122

On Fri, Nov 28, 2014 at 11:03 AM, Ilan Biala [email protected]
wrote:

Any progress on this?


Reply to this email directly or view it on GitHub
#462 (comment).

@tacomilkshake
Copy link

I assume it's the 1.x branch? Is documentation updated in that branch for the code re-write? Thanks in advance.

@ilanbiala
Copy link

@bnoguchi how about getting some help from a strong contributor?

@nponeccop
Copy link

nponeccop commented Apr 6, 2020

I'm doing something different from both 0.5.x and 1.x branches, namely I've made Google working with examples/server.js, while replacing everything deprecated, such as jade with pug and bumping express to 4.x along with other dependencies.

See also #488 for my (original) plan.

My branch is master...nponeccop:hotfix-0.4.10

If we end with something viable, we can release it to npm in a namespace such as @foo/everyauth, and move on without any participation from @bnoguchi.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests