Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSON schema checking to guard against invalid config.json #101

Open
mackshot opened this issue Jun 29, 2023 · 3 comments
Open

Add JSON schema checking to guard against invalid config.json #101

mackshot opened this issue Jun 29, 2023 · 3 comments

Comments

@mackshot
Copy link

Hi,

i updated to the latest docker image benkl/firefly-iii-fints-importer:latest
Digest:sha256:b48f6f1c6373c462271932401b45c1620557f042ce156d44d0a66fe9b5eeafed

Since then I got stucked after the dialog

Continue to next step
Continuing to next step in 2 seconds.

The connection to your bank was tested sucessfully.

The following POST requests will not come to an end. The log does not contain any useful information

[Thu Jun 29 17:59:47 2023] 192.168.5.100:40648 Accepted
[Thu Jun 29 17:59:48 2023] 192.168.5.100:40648 Closing
[Thu Jun 29 17:59:48 2023] 192.168.5.100:40664 Accepted
[Thu Jun 29 17:59:48 2023] 192.168.5.100:40664 Closing
[Thu Jun 29 17:59:50 2023] 192.168.5.100:39970 Accepted
[Thu Jun 29 17:59:50 2023] 192.168.5.100:39970 Closing
[Thu Jun 29 17:59:51 2023] 192.168.5.100:39978 Accepted
[Thu Jun 29 17:59:51 2023] 192.168.5.100:39978 Closing
[Thu Jun 29 17:59:53 2023] 192.168.5.100:39984 Accepted

Does anybody else have this problem after updating to the latest docker image?
How to debug it?

Thank you very much!
/Markus

@dklinger
Copy link

dklinger commented Jul 3, 2023

I am having the same issue, but one step later.
It stucks and shows a white page after hitting the Import-button.
image

The log looks the same as yours.

@mackshot
Copy link
Author

I have set up a new docker container using the docker image and created a new configuration as well. Since then it works for me. Nevertheless I would be happy to get an idea how to debug problems in future to be able to report or help to fix problems. @dklinger is your problem still there?

@bnw
Copy link
Owner

bnw commented Jul 23, 2023

Yes, this is a good point. The whole import is not well guarded against an incorrect (aka old) config.json. This could be addressed e.g. with a simple json schema checking.

@bnw bnw changed the title benkl/firefly-iii-fints-importer stuck in sync Add JSON schema checking to guard against invalid config.json Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants