Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors are not accessible since they are private with a lower case #130

Closed
d4z3x opened this issue Nov 22, 2023 · 1 comment
Closed

Errors are not accessible since they are private with a lower case #130

d4z3x opened this issue Nov 22, 2023 · 1 comment
Assignees
Labels
wontfix This will not be worked on

Comments

@d4z3x
Copy link

d4z3x commented Nov 22, 2023

Shoulnd't the the errors defined in sevenzip be accessible for comparison? Currently, errors are defined with leading lower case, therefore, parking them private to external modules. archive/zip uses "ErrFormat", but this module uses "errFormat."

Can we fix this please?

@bodgit bodgit self-assigned this Nov 17, 2024
@bodgit bodgit added the wontfix This will not be worked on label Nov 17, 2024
@bodgit
Copy link
Owner

bodgit commented Nov 17, 2024

There's a bunch of errors that can be returned aside from [eE]rrFormat and I don't want to have to export them all because they then have to be maintained. Checking with err != nil should be sufficient.

However, I have just merged #278 which wraps most read-type errors which primarily is useful for ascertaining if some sort of encryption was involved, for the purposes of handling wrong passwords.

@bodgit bodgit closed this as completed Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants