Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excuse me, who can reproduce the numerical values of msvdqa data used in the paper (top 1 accuracy 60%) #27

Open
lxrrrrrr opened this issue Jul 18, 2024 · 9 comments

Comments

@lxrrrrrr
Copy link

I just used an A800 and changed the batch size to 32. The other parameters are consistent with the appendix of the paper. Why can I only achieve 53%

@lxrrrrrr
Copy link
Author

I feel like I might have missed something somewhere, let me take a closer look

@hulianyuyy
Copy link

I can roughly achieve ~60% accuracy on msvd.

@hulianyuyy
Copy link

But i can only get ~42% on msrvtt.

@lxrrrrrr
Copy link
Author

I think part of the reason is the way the dataset is processed. Are you using the annotations provided by the author?

@hulianyuyy
Copy link

Yes, i use the annotations provided by the author. Maybe the problem is related to this.

@lxrrrrrr
Copy link
Author

Many thanks for your
then I processed the data according to the code you provided and re-downloaded the msvd dataset using download_scripts in the code, but I can't use annotations provided by the author, there are a lot of data length mismatch will report an error, may I ask you how to deal with it, looking forward to your reply

@hulianyuyy
Copy link

You may simply reduce the total num_frames by 1 or 2 in the dataset.py for each dataset.

@boheumd
Copy link
Owner

boheumd commented Jul 28, 2024

Many thanks for your then I processed the data according to the code you provided and re-downloaded the msvd dataset using download_scripts in the code, but I can't use annotations provided by the author, there are a lot of data length mismatch will report an error, may I ask you how to deal with it, looking forward to your reply

Following this #3 (comment). You can update the "frame_length" to your actual extracted frame length for each video in the annotation file.

@chhchan
Copy link

chhchan commented Oct 27, 2024

hello, I met the same problem, may I ask if you reproduce the value in the paper now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants