REF: fix private imports for q2-types refactor #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full distro trial here: https://github.com/qiime2/distributions/actions/runs/10084580203?pr=314 |
lizgehret
approved these changes
Jul 31, 2024
|
Tests won't pass until this is merged. We'll need another override, sorry @misialq! |
|
Psst, little bump @misialq 🤓 sorry to keep bothering you with these! |
|
Again, sorry @lizgehret, @ebolyen: I have neglected GitHub recently a bit - merging now! 🙇 |
DorielaGrabocka
pushed a commit
to DorielaGrabocka/q2-assembly
that referenced
this pull request
Aug 29, 2024
misialq
added a commit
that referenced
this pull request
Sep 20, 2024
* ENH: action to convert FeatureData to Genome data added * ENH: action to convert FeatureData to Genome data refined * ENH: action to convert FeatureData to Genome data tests added * ENH: set up test paths added * ENH: imports modified * REF: fix private imports for q2-types refactor (#95) * ENH: changes requested done * ENH: imports modified * ENH: description modified * Update q2_assembly/plugin_setup.py * ENH: tests modified * ENH: tests modified * ENH: checking for duplicate IDs code added * ENH: accounting for duplicates case * ENH: accounting for duplicates case, modifying tests to check file content * ENH: code refactoring * ENH: tests corrected * Update q2_assembly/helpers/helpers.py --------- Co-authored-by: Evan Bolyen <[email protected]> Co-authored-by: Michal Ziemski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some private imports and uses a utility to get the same effect.
Related to: qiime2/q2-types#342