-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: New type called AMRFinderPlusDatabase
#81
ENH: New type called AMRFinderPlusDatabase
#81
Conversation
Hey @misialq Those would be 8 new formats so Im not so sure if that even makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once you change the directory format as I pointed out above, you can remove most of those test files - they are just polluting the repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left them there, because if I remove most files, the test would become meaningless.
Only like this it is actually tested if all regex expressions work with the database files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you think it will become meaningless? Your test should just make sure that the regex is working - for this you don't need all the files for all the species - you could just keep a set of those for, say, two taxa and remove everything else (now that you have the FileCollection in place).
Hi @misialq could you have another look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
This reverts commit fb9e4b5.
solves #80
This new type is used for the storage of the database for the amrfinderplus tool.
Set up an environment
https://github.com/bokulich-lab/q2-amr?tab=readme-ov-file#installation
Run it locally
Download test files
amrfinderplus_database.zip: https://polybox.ethz.ch/index.php/s/nJmbGpkM1ywS9VW
Test it out!