-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Added new action that can download AMRFinderPlus database called fetch_amrfinderplus_db
#82
ENH: Added new action that can download AMRFinderPlus database called fetch_amrfinderplus_db
#82
Conversation
Hey can you have a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It runs as expected and the tests pass. Check some comments that I made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me!
95242a3
to
1f252ac
Compare
Hi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good to me @VinzentRisch . Just a minor change in the comments.
8307707
to
c12d56c
Compare
Hi @ChristosMatzoros I changed the function copy_all slightly with a different regex. Could you run the function again to see if all works well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine!
…e called `fetch_amrfinderplus_db` (bokulich-lab#82)" This reverts commit 38e48b5.
solves #77
AMRFinderPlusDatabase
.Set up an environment
Run it locally