Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: added database_format_version.txt to AMRFinderPlusAnnotationsDirFmt #92

Merged

Conversation

VinzentRisch
Copy link
Collaborator

@VinzentRisch VinzentRisch commented Jul 16, 2024

solves #91

Set up an environment

https://github.com/bokulich-lab/q2-amr?tab=readme-ov-file#installation

Run it locally

  1. First, clone the repo and checkout the PR branch:
git clone https://github.com/bokulich-lab/q2-amr.git
cd q2-amr
git fetch origin pull/92/head:pr-92
git checkout pr-92
pip install -e .
  1. Download test files
    amrfinderplus_database.zip: https://polybox.ethz.ch/index.php/s/nJmbGpkM1ywS9VW

  2. Test it out!

qiime tools import --input-path database --output-path database.qza --type AMRFinderPlusDatabase 

Copy link
Contributor

@ChristosMatzoros ChristosMatzoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @VinzentRisch ,

Works as expected. I also exported the artifact to make sure the database_format_version.txt file is there. I think the CI passed, so you can merge!

@VinzentRisch VinzentRisch merged commit d785a0e into bokulich-lab:main Jul 16, 2024
2 checks passed
VinzentRisch added a commit to VinzentRisch/q2-rgi that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants