Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing dependencies #49

Open
3 of 6 tasks
indomitableSwan opened this issue Jul 29, 2022 · 5 comments
Open
3 of 6 tasks

missing dependencies #49

indomitableSwan opened this issue Jul 29, 2022 · 5 comments
Assignees
Labels
cryptography documentation Improvements or additions to documentation

Comments

@indomitableSwan
Copy link
Contributor

indomitableSwan commented Jul 29, 2022

In current-development-phase.md, there are the following missing dependencies with an unlinked TODO comment:

To close this issue, appropriate dependencies should be selected and referenced. Ideally, we incorporate a habit of commenting on our level of confidence in our selected dependencies.

Please also include compatible parameter selections and remove the guidance around "inter-dependency constraints" on the "Operations on Arbitrary Secrets" page (cryptographic_flows.md)

@indomitableSwan
Copy link
Contributor Author

There is some overlap with other issue, so I added links in the description and flagged dependency relationships.

@indomitableSwan indomitableSwan added the documentation Improvements or additions to documentation label Aug 15, 2022
@indomitableSwan
Copy link
Contributor Author

@marsella Is this issue done? Do we want to add any additional notes about the the CSPRNG at the top-level? Realizing that when we closed #98, we didn't add any additional details here, just a note here for generate.

See

- [TODO #49](https://github.com/boltlabs-inc/key-mgmt-spec/issues/49): Add dependency information for the above.
for one part of spec that should be updated with the TODO note removed after completion.

Question: Should the location of this information change? Where would you expect to find dependency information listed out in detail? Should this information be on the Systems Architecture page instead? Somewhere else?

@marsella
Copy link
Contributor

I think it makes sense to add a note about CSPRNGs in the cryptographic protocol and implementation dependencies section (where the TODO is linked). To match the other dependencies, that would be

  • describe CSPRNG abstraction we're using (Rust's CryptoRng trait)
  • list the selection we're using (I think StdRng shared across threads)

I'd also move the "implementation guidance" note in generate to the "external dependencies" section, since that's true everywhere we use CSPRNGs.

@indomitableSwan
Copy link
Contributor Author

indomitableSwan commented Aug 30, 2022

Also added new items to track ECDSA/EdDSDA and MAC.

@indomitableSwan
Copy link
Contributor Author

I think it makes sense to add a note about CSPRNGs in the cryptographic protocol and implementation dependencies section (where the TODO is linked). To match the other dependencies, that would be

  • describe CSPRNG abstraction we're using (Rust's CryptoRng trait)
  • list the selection we're using (I think StdRng shared across threads)

This plan sounds fine to me.

I'd also move the "implementation guidance" note in generate to the "external dependencies" section, since that's true everywhere we use CSPRNGs.

I'd rather just repeat the note wherever it's applicable. Increases the odds that the person implementing sees a reminder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cryptography documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants