Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce duplication in end-to-end tests #496

Open
marsella opened this issue Sep 19, 2023 · 0 comments
Open

Reduce duplication in end-to-end tests #496

marsella opened this issue Sep 19, 2023 · 0 comments

Comments

@marsella
Copy link

There's a lot of duplicated code within each end-to-end tests, and semi-duplicated functionality across the two current existing ones (one which runs signing manually, and one which runs interactive signing).

Some of the changes between manual and interactive tests involve simplification of the protocol-running infrastructure (see, e.g. the process_message function and its parameters in manual, as compared to the implementation in the interactive signing test). The primary change was simplifying the inbox that holds in-process messages

Overall, each protocol execution is virtually identical up to input and output types. Consider writing a more generic function to run a single protocol, and refactoring the tests with calls to this function.

Related issue: #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant