Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure secret and zeroize on drop apply only to lowest-level secret types #330

Open
marsella opened this issue Apr 28, 2023 · 0 comments · May be fixed by #511
Open

Make sure secret and zeroize on drop apply only to lowest-level secret types #330

marsella opened this issue Apr 28, 2023 · 0 comments · May be fixed by #511

Comments

@marsella
Copy link

marsella commented Apr 28, 2023

For the bottom-up approach described in #250 , it's helpful to ensure that only the "lowest-level" types that are secret have ZeroizeOnDrop applied to them. Review the list of types that have this annotation. For any compound types (e.g. structs) whose fields are all private (or a mix of private and public with public ones flagged), remove the ZeroizeOnDrop derivation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants