Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create chain-agnostic ArbiterClient trait #346

Open
marsella opened this issue Jan 10, 2022 · 0 comments
Open

Create chain-agnostic ArbiterClient trait #346

marsella opened this issue Jan 10, 2022 · 0 comments

Comments

@marsella
Copy link
Contributor

As a first draft of our chain agnostic design, we'll try to decouple the zeekoe implementation from the specific Tezos instantiation. We anticipate that closing will be similar for most chains, while establishing may be slightly to very different (e.g. depending on the number of operations required, whether it's efficient to batch establishing and funding, etc). However, we will start by just defining a trait that includes all the functions currently called for the TezosClient. Then, refactor the main body of zeekoe to use the trait instead of hardcoded Tezos calls.

Expected places that need changing:

  • all the chain operations
  • config file; maybe it'll need some additional structure to group the arbiter config items in a sub-element with defaults defined by the trait instantiation
  • database storage: we specifically hold the keys as blobs, but we might want to adjust the naming in order to be more generic.

This decision per discussion with @gijsvl, @indomitableSwan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant