Skip to content
This repository has been archived by the owner on Jul 1, 2021. It is now read-only.

[Feature Request] Option to show damage in terms of half-hearts #19

Open
Minamikaze392 opened this issue Aug 22, 2018 · 4 comments
Open

Comments

@Minamikaze392
Copy link

It will be great if this option is availabe, because vanilla minecraft and many other mods are using half-hearts as unit when showing damages / health.

@DoomRater
Copy link

I'm pouring over the source now because I want to make this change myself and I'm not sure where to best make this adjustment. It looks like the best place to do this is right at the beginning of the damage event itself, because it's Minecraft itself that is reporting the damage in full hearts as opposed to half hearts.

@DoomRater
Copy link

Wait... there's a resistance time check and if I do it too early, the dummy's damage resistance will be longer than it should be for small damage values from the hand.

@bonii-xx
Copy link
Owner

If you really want to do this, then you don't need to check the calculations at all. It's just a display thing. The part where the damage is displays just needs to convert the "x.yz" to "a.bc ❤️". Simple division with a bit of rounding when setting the displayed number.

@DoomRater
Copy link

Division? The damage displayed is already in terms of full hearts. But tooltips show damage in half hearts. Multiplication by 2 yields the value expected.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants