Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main thread for feature parity between Classic and 7-Style skins #84

Open
bonzibudd opened this issue Mar 29, 2021 · 7 comments
Open

Main thread for feature parity between Classic and 7-Style skins #84

bonzibudd opened this issue Mar 29, 2021 · 7 comments
Labels
feature/enhancement Request for new feature or enhancement

Comments

@bonzibudd
Copy link
Owner

bonzibudd commented Mar 29, 2021

Some features will be inherently different due to the respective layout features of each, but I will make sure visual appearances stay as similar as possible.

This currently includes:

  • Automatic colorization (entire menu) Completed
  • Images for menu/submenu backgrounds Completed
  • Paddings
  • Layout options
  • User image sizes Not currently planned
  • Search box appearance/scaling
  • Selector styles Completed
@bonzibudd bonzibudd added the feature/enhancement Request for new feature or enhancement label Mar 29, 2021
@bonzibudd bonzibudd pinned this issue Mar 29, 2021
@bonzibudd
Copy link
Owner Author

Some status updates:

image
New selection style added to the classic port.

Also, some more layout options for the two columns style:
image

@bonzibudd
Copy link
Owner Author

I've started porting the new background images to the classic styles. Will be a slow process sadly.

@bonzibudd
Copy link
Owner Author

I went ahead and ported the BMPs to PNGs, so the file size is once again decreased. I also added the new 192DPI images to improve scaling.

@bonzibudd
Copy link
Owner Author

Status update for classic styles:

I think I have figured out how the immersive menu colors are going to work with the embedded Search box background. The mask colors now operate in a way that there are 3 colors preserved for the immersive color, static white, and static black. This should theoretically allow for any automatic blend of those colors if they are used correctly. I will implement them first on the 7-style with the correct colors, and then port them directly as they will use the same colors.

Additionally, I have updated the margins of the background images so they will support up to 144 DPI, an improvement from just 96 DPI previously. This includes the increased margins needed for the extra padding and more search padding options.

@bonzibudd
Copy link
Owner Author

image

I have finally mostly finished the classic style backgrounds with up to 144 DPI support. The next steps will be:

  • Adding options for padding around Search
  • Adding "Extra padding" option for menu overall
  • Using Immersive colors by default

@bonzibudd
Copy link
Owner Author

Support for full immersive colors has been added, with more accurate background colors. I am holding off on adding the different options for search and padding, because I’m not sure that I will be keeping the paddings the same. I will see what works best with the 7-style skins with/without the bigger font enabled, and go from there.

@bonzibudd
Copy link
Owner Author

The next thing I will work on will be adding support for a non-floating mode for the classic style skins. I will probably end up making that style the default.

@bonzibudd bonzibudd unpinned this issue Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/enhancement Request for new feature or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant