Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC CI may not take effect #1223

Open
FantasqueX opened this issue Dec 10, 2023 · 5 comments · May be fixed by #1224
Open

MSVC CI may not take effect #1223

FantasqueX opened this issue Dec 10, 2023 · 5 comments · May be fixed by #1224

Comments

@FantasqueX
Copy link
Contributor

As you can see in the latest CI result, warning: Did not find command for MSVC toolset. If you have Visual Studio 2017 installed you will need to specify the full path to the command, set VS150COMNTOOLS for your installation, or build from the 'Visual Studio Command Prompt for VS 2017'. and no test is executed.

The problem is that there is no msvc-15 or msvc-16. MSVC supports c++14 from vs2015 a.k.a. msvc-14.0. b2_toolset should be

b2_toolset: [
  msvc-14.0,
  msvc-14.1,
  msvc-14.2,
  msvc-14.3,
]
@vissarion vissarion linked a pull request Dec 12, 2023 that will close this issue
@vissarion
Copy link
Member

Thanks for opening this. It seems that msvc-14.0 -- msvc-14.2 return the same error (see #1224). Probably there is a need for extra setting to make them work on CI.

@FantasqueX
Copy link
Contributor Author

On my machine (Windows 11 with vs2019 installed), ./b2 toolset=msvc-14.2 works well.
According to Github action documentation, both vc142 and vc143 of vs2022 are installed. I don't know why b2 cannot find vc142. Maybe some more investigation needs to be done.

@barendgehrels
Copy link
Collaborator

@vissarion , this looks outdated, can we close it?

@vissarion
Copy link
Member

@barendgehrels the warning still exists in latest CI (the minimal / msvc-15 and minimal / msvc-16 jobs are green but there is a hidden warning and actually tests are not run at all).

@barendgehrels
Copy link
Collaborator

OK thanks for checking. Then we can keep it open.
Personally, I don't use b2 anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants