Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider moving channel_convert_to_unsigned out of detail namespace #706

Open
mloskot opened this issue Jul 4, 2022 · 0 comments
Open
Labels
cat/refactoring Any nonfunctional changes
Milestone

Comments

@mloskot
Copy link
Member

mloskot commented Jul 4, 2022

From @marco-langer #703 (comment)

Regarding this channel_convert_to_unsigned, which is now in the detail namespace, but also still referenced in this tutorial:

Maybe one should think to pull it out of the detail namespace again, if it is that useful for client code? I don't know the rational why it was moved into the detail namespace at all (this was done 15 years ago!).

I think, it is worth to keep this discussion open and come back to it in future.


For the records, it moved into detail in 2ad6747
which refers to the "GIL 2.0 to GIL 2.1 Changes" PDF. Since I have got this gil2.1_changes.pdf, I've attached it for the reference. It does not explain the move rationale though.

I attached also earlier gil2.0_changes.pdf which lists lots of changes related to Boost'ification of the Adobe GIL library. This makes me guess that moving of the types into the detail namespace may be related to the unification of GIL according to Boost conventions.

(both legacy documents available at https://github.com/boostorg/gil/wiki/History)

@mloskot mloskot added the cat/refactoring Any nonfunctional changes label Jul 4, 2022
@mloskot mloskot added this to the Boost 1.81+ milestone Jul 7, 2022
@mloskot mloskot modified the milestones: Boost 1.82, Boost 1.83+ Mar 31, 2023
@mloskot mloskot modified the milestones: Boost 1.86, 1.87.0 Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat/refactoring Any nonfunctional changes
Projects
None yet
Development

No branches or pull requests

1 participant