Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icl/iterator.hpp and icl/detail/element_iterator.hpp include <boost/config/warning_disable.hpp> #29

Open
pgroke-dt opened this issue Oct 12, 2020 · 1 comment

Comments

@pgroke-dt
Copy link

icl\iterator.hpp and icl\detail\element_iterator.hpp include <boost/config/warning_disable.hpp>. This disabled the MSVC warning C4996 without re-enabling it again.

For context: C4996 is MSVC's warning for using deprecated stuff. This means code that uses Boost.Icl will not get warning C4996 which IMO is quite bad. <boost/config/warning_disable.hpp> even contains the following comment:

//  IT SHOULD NOT BE INCLUDED BY ANY BOOST HEADER.
//
//  YOU SHOULD NOT INCLUDE IT IF YOU CAN REASONABLY FIX THE WARNING.
@brunom
Copy link
Contributor

brunom commented Dec 21, 2021

Still broken in 1.78

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants