Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reading server pushes in batches #152

Closed
mzimbres opened this issue Sep 4, 2023 · 0 comments · Fixed by #153
Closed

Enable reading server pushes in batches #152

mzimbres opened this issue Sep 4, 2023 · 0 comments · Fixed by #153

Comments

@mzimbres
Copy link
Collaborator

mzimbres commented Sep 4, 2023

At the moment the asio::channel used to communicate server pushes to the user via async_receive has size 0, which is inefficient under heavy load. Given that the generic_response can contain multiple responses and pushes, there would be no problem is making the channel size configurable by the user.

The implementation should also use the try_send/receive functions to avoid suspension when possible.

It should be also documented that a generic_response might contain multiple server pushes for channels with size != 0 and how to iterate over them, which at the moment must be done by checking nodes with depth 0. In the future we will add a nicer way of iterating over individual messages in a response.

@mzimbres mzimbres linked a pull request Sep 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant