Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RayInput not working for non-top level cameras ? #33

Open
charlesfleche opened this issue Feb 7, 2018 · 0 comments
Open

RayInput not working for non-top level cameras ? #33

charlesfleche opened this issue Feb 7, 2018 · 0 comments

Comments

@charlesfleche
Copy link

charlesfleche commented Feb 7, 2018

Is RayInput expecting a camera that is a direct child of a Scene ? The arm model seems to expect a camera whose local matrix is directly driven by getFrameData. That is the way THREE works at render time to get the VR cameras: https://github.com/mrdoob/three.js/blob/608fb12d7cdb7d9bdce193d9c9e63fa082b8de81/src/renderers/webvr/WebVRManager.js#L108

However, the RayRenderer directly receives a local matrix:

this.renderer.setPosition(modelPose.position);

Which means that if the camera is down a hierarchy, the RayCaster ray origin and orientation won't be set correctly: they'll be set in camera local coordinates, not world coordinates as they should be.

Is that the intended behavior or am I missing something here ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant