turn all warnings into errors but ignore type punning for franka_hard…

…ware
boschresearch · Oct 30, 2024 · b1b5158 · b1b5158
1 parent b71db91
commit b1b5158
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 7 deletions.
diff --git a/franka_example_controllers/CMakeLists.txt b/franka_example_controllers/CMakeLists.txt
@@ -8,7 +8,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Wall -Wextra -Wpedantic)
+    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/franka_gripper/CMakeLists.txt b/franka_gripper/CMakeLists.txt
@@ -6,7 +6,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Wall -Wextra -Wpedantic)
+    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
 endif()
 
 find_package(ament_cmake REQUIRED)

diff --git a/franka_hardware/CMakeLists.txt b/franka_hardware/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Wall -Wextra -Wpedantic)
+  add_compile_options(-Werror -Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/franka_hardware/test/CMakeLists.txt b/franka_hardware/test/CMakeLists.txt
@@ -2,5 +2,7 @@ find_package(ament_cmake_gmock REQUIRED)
 
 ament_add_gmock(${PROJECT_NAME}_test franka_hardware_interface_test.cpp)
 target_include_directories(${PROJECT_NAME}_test PRIVATE ${CMAKE_CURRENT_SOURCE_DIR}/../include)
-
 target_link_libraries(${PROJECT_NAME}_test  ${PROJECT_NAME})
+
+# ignore type punning via 'reinterpret_cast<double*>(&[...])'
+target_compile_options(${PROJECT_NAME}_test PRIVATE -Wno-error=strict-aliasing)
diff --git a/franka_robot_state_broadcaster/CMakeLists.txt b/franka_robot_state_broadcaster/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Wall -Wextra -Wpedantic)
+    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/franka_semantic_components/CMakeLists.txt b/franka_semantic_components/CMakeLists.txt
@@ -7,7 +7,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-  add_compile_options(-Wall -Wextra -Wpedantic)
+  add_compile_options(-Werror -Wall -Wextra -Wpedantic)
 endif()
 
 option(CHECK_TIDY "Adds clang-tidy tests" OFF)

diff --git a/integration_launch_testing/CMakeLists.txt b/integration_launch_testing/CMakeLists.txt
@@ -8,7 +8,7 @@ if(NOT CMAKE_CXX_STANDARD)
 endif()
 
 if(CMAKE_COMPILER_IS_GNUCXX OR CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-    add_compile_options(-Wall -Wextra -Wpedantic)
+    add_compile_options(-Werror -Wall -Wextra -Wpedantic)
 endif()
 
 # find dependencies