Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New mechanism to clean jupyter notbooks before committing #31

Open
johannes-mueller opened this issue Sep 18, 2023 · 2 comments
Open

New mechanism to clean jupyter notbooks before committing #31

johannes-mueller opened this issue Sep 18, 2023 · 2 comments

Comments

@johannes-mueller
Copy link
Member

johannes-mueller commented Sep 18, 2023 •
edited
Loading

It turns out that the mechanism in place is not ideal.
@johannes-mueller johannes-mueller mentioned this issue Sep 18, 2023
Closed
@maierbn
Copy link
Contributor

maierbn commented Oct 13, 2023

One issue is on Windows with sourcetree, it runs the nbclean git hook whenever the status in the GUI is refreshed. For doing a single commit, this happens multiple times and leads to wait times of ~half a minute (when ~5 jupyter notebooks were changed)

@maierbn
Copy link
Contributor

maierbn commented Oct 13, 2023

A suggestion would be to implement them as precommit hooks.

@johannes-mueller johannes-mueller mentioned this issue Jul 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@johannes-mueller @maierbn