Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SQS endpoints #2151

Closed
benoit74 opened this issue Sep 15, 2020 · 4 comments
Closed

Update SQS endpoints #2151

benoit74 opened this issue Sep 15, 2020 · 4 comments
Assignees
Labels
breaking-change Issue requires a breaking change to remediate. duplicate This issue is a duplicate.

Comments

@benoit74
Copy link

I'm opening this issue to try to get some attention on #1418 which is Closed but should be reopened according to my PoV and the one of other users. I know this is not a good habit but I'm quite desperate to have some attention since it has been more than 8 months since my original request to reopen this.

A small explanation :

  • Botocore as of 1.9.15 still returns SQS queue URLs according to the {region}.queue.{suffix} pattern
  • This is legacy according to AWS
  • The new pattern is sqs.{region}.amazonaws.com
  • This causes issues in some cases (e.g. when using an SQS VPC Endpoint which supports only the new URL)
  • This was kept as is in 2018 due to Python 2.6 support. Since then, Python 2.6 support has been dropped and there is hence probably no more blocker to change this

Any chance to have someone look into it and fix this? Thank you very much in advance

@benoit74 benoit74 added the needs-triage This issue or PR still needs to be triaged. label Sep 15, 2020
@swetashre swetashre self-assigned this Sep 17, 2020
@swetashre
Copy link
Contributor

@benoit74 - Thank you for your post. We would need to drop support for python 2.6-2.7.8. Even then it would still be a breaking change because people have whitelists for particular urls, so changing what we use would break them.

For workaround you can use endpoint_url. Something like this:

sqs = boto3.client('sqs',endpoint_url='https://sqs.us-west-2.amazonaws.com')
sqs.list_queues()
Out[87]: 
{'QueueUrls': ['https://sqs.us-west-2.amazonaws.com/12345678901/myqueue'],}

This issue is related to issue boto/boto3#1900

@swetashre swetashre added breaking-change Issue requires a breaking change to remediate. duplicate This issue is a duplicate. and removed needs-triage This issue or PR still needs to be triaged. labels Sep 18, 2020
@czechnology
Copy link

Manually setting endpoint_url parameter is surely a solution (which I also use to be able to use the SQS VPC endpoint).
However, I wonder if a solution similar to the sts_regional_endpoints would be applicable here. Keep legacy option as the default value but let users opt in for the new pattern, using config or environment variable.

@swetashre
Copy link
Contributor

Let's track this issue under the Github issue boto/boto3#1900. I am closing this one as duplicate.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Issue requires a breaking change to remediate. duplicate This issue is a duplicate.
Projects
None yet
Development

No branches or pull requests

3 participants