Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactoring: migrate to zerolog #38

Closed
wants to merge 8 commits into from
Closed

refactoring: migrate to zerolog #38

wants to merge 8 commits into from

Conversation

REDHAT3
Copy link

@REDHAT3 REDHAT3 commented Oct 28, 2020 •
edited
Loading

close #32

@REDHAT3 REDHAT3 marked this pull request as draft October 28, 2020 16:31
@mr-linch mr-linch changed the title feat(logger): change logger pkg refactoring: migrate to zero log Oct 28, 2020
@mr-linch mr-linch changed the title refactoring: migrate to zero log refactoring: migrate to zerolog Oct 28, 2020
@codecov-io
Copy link

codecov-io commented Oct 28, 2020 •
edited
Loading

Codecov Report

Merging #38 into master will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #38      +/-   ##
==========================================
- Coverage   19.69%   19.55%   -0.15%     
==========================================
  Files          10       10              
  Lines         533      537       +4     
==========================================
  Hits          105      105              
- Misses        414      418       +4     
  Partials       14       14
Impacted Files Coverage Δ
main.go 2.08% <0.00%> (-0.06%) ⬇️
store/postgres/file.go 0.00% <0.00%> (ø)
store/postgres/postgres.go 65.71% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update daef1b2...c35a6e4. Read the comment docs.

@REDHAT3
Copy link
Author

REDHAT3 commented Oct 28, 2020

Screenshot from 2020-10-28 19-23-39
Screenshot from 2020-10-28 19-24-06

@REDHAT3
Copy link
Author

REDHAT3 commented Oct 28, 2020

Не понял как тут поменять чтобы передавать Values, делаю как в доке, выдает ошибку
Screenshot from 2020-10-28 19-26-51

@REDHAT3 REDHAT3 marked this pull request as ready for review October 29, 2020 15:11
@REDHAT3 REDHAT3 requested a review from mr-linch October 29, 2020 15:33
@mr-linch mr-linch closed this Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr-linch mr-linch Awaiting requested review from mr-linch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to zerolog
3 participants
@REDHAT3 @codecov-io @mr-linch