Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add upstream changes #5

Merged
merged 5 commits into from
Mar 3, 2023
Merged

Add upstream changes #5

merged 5 commits into from
Mar 3, 2023

Conversation

richardw347
Copy link

@richardw347 richardw347 commented Mar 1, 2023 •
edited
Loading

This PR adds in changes from the upstream repository. The main things that have changed are:

  • Added a magnetometer calibration action
  • Cleaned up the register code to remove some duplication
  • Added a separate configure_sensor function

coalman321 and others added 5 commits February 10, 2023 12:39
@coalman321 @dawonn
add HSI calibration action server
d009110
@coalman321 @dawonn
tested recalibration on vn100T as working
e8261cb
@coalman321 @dawonn
working procedure
b60259a 
Most of the time, the device will return to running. occasionally the device will time out.
recovery can be done by recalibrating or resarting
@coalman321 @dawonn
de-duplicate code for same register layouts
2e0c1f1
@richardw347
merge in changes from upstream
addb754
@richardw347 richardw347 mentioned this pull request Mar 1, 2023
Merged
@richardw347 richardw347 marked this pull request as ready for review March 3, 2023 11:51
@richardw347 richardw347 requested a review from scheunemann March 3, 2023 11:51
scheunemann
scheunemann approved these changes Mar 3, 2023
View reviewed changes
Copy link
Collaborator

@scheunemann scheunemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to get it in before we test their driver and build on the changes 👍 thank you!

@richardw347 richardw347 merged commit 8f9742d into bau Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheunemann scheunemann scheunemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richardw347 @scheunemann @coalman321